TheDeathlyCow / scorchful

A heat mod for Minecraft Fabric and Quilt. Sister mod to Frostiful.
GNU Lesser General Public License v3.0
7 stars 1 forks source link

Make Sand Piles formation more configurable for Thermoo Patches #63

Open Chribit opened 5 months ago

Chribit commented 5 months ago

Is your feature request related to a problem? Please describe. I'm currently putting together a nice little mod pack for me and my friends and amongst others, I've added "Immersive Weathering" and "Scorchful". Both of these mods add sand layers - or "sandy" versions of snow layers. Both look identical when placed, the only difference being the item form. They obviously can't be stacked on top of each other, but both are generated in the world one way or the other. This leads to confusion for players and also potentially unappealing visuals in the desert since some sand piles seam to accumulate during sand storms but others don't.

Describe the solution you'd like I think this could be solved by checking for Immersive Weathering usage alongside Scorchful and then resolving this conflict somehow. Maybe utilise Immersive Weathering's sand piles instead of Scorchful's if available? I'd be happy to post a similar issue on Immersive Weathering's issue page if you want. Just would be sick if these two mods were fully compatible mechanics wise.

TheDeathlyCow commented 5 months ago

This sounds like something that could be implemented in Thermoo Patches

Chribit commented 5 months ago

Oh yes absolutely! I wasn't aware that mod existed for some reason - gotta install that as well since i'm also using fabric seasons and ad astra :D

Should i repost this issue to that repo?

TheDeathlyCow commented 5 months ago

Yeah I think this would be a good issue to open up over there, not here.

Chribit commented 5 months ago

reposted in Thermooo Patches repo: https://github.com/TheDeathlyCow/thermoo-patches/issues/7

I guess this can be closed?

TheDeathlyCow commented 5 months ago

thanks. yeah i guess this can be closed. though i think i'll still need to make some changes to scorchful too to make this a little less painful to implement.