search

TheDesignExchange / app

The main Design Exchange site.
http://thedesignexchange.herokuapp.com
5 stars 1 forks source link

Minor bug fixes to make it clearer to user #157

Closed thuangy closed 8 years ago

grmarcil commented 8 years ago

Looks good @thuangy! I'll release this to staging then if all looks good there I'll have you merge and release to production.

grmarcil commented 8 years ago

Looks good, but I think the Markdown link could be improved in two ways.

image

  1. Use target="_blank" in the link to open markdown guide in a new tab to avoid taking users out of editing workflow.
  2. Eliminate unevenness in two text boxes. You could just move the link below each meltdown box, or above it, near the "more info" links.
thuangy commented 8 years ago

@grmarcil Does it look a little better now?

grmarcil commented 8 years ago

Actually I think the first position was better, but the link target blank is good. I just compared with master, it looks like the un-evenness is actually from the meltdown library itself, and I can't figure out why from a quick glance at the css so probably not worth worrying about.

Can you keep the target blank, but change the position back to the previous one? Message me after that and I'll go through the release with you.

thuangy commented 8 years ago

Okay, I moved it back!

grmarcil commented 8 years ago

Closes #152, #153, #105