search

TheDesignExchange / app

The main Design Exchange site.
http://thedesignexchange.herokuapp.com
5 stars 1 forks source link

Admin feature improve #169

Closed james--jiang closed 8 years ago

grmarcil commented 8 years ago

General feedback, more specific comments inline with code

  1. Deleting a characteristic should require at least one warning dialog (eg "Are you sure you want to delete this characteristic? Doing so will permanently erase the characteristic and its association with all methods.") and a checkbox confirming that the user understands.
  2. After deleting a characteristic, you should go back to the admin panel, not the characteristics index. See for example how Tina did this with adding a design method to a collection from the design method show page.
  3. Same with editing a characteristic, the user should go back to the administrator page when done
  4. I think it would be good to modify the pager to indicate what you are picking from the two dropdowns (eg "10 rows per page" rather than "10" and "Page 1" rather than "1")

James: Fixed all the issues except currently not able to add a checkbox to the confirmation dialog.

grmarcil commented 8 years ago

Okay @james--jiang my comments are finished. Look over the suggestions I made and let me know when you want to review again.

grmarcil commented 8 years ago

Lots of comments, but mostly just reminding you of cleanup details. The functionality here all looks good and bug free as far as I can tell.