Pins cover map as you click around (even if you don't save the pins)

TheDevPath / Navi

Open Source Project for Grow with Google Udacity Scholarship Challenge - Navigation app using offline first strategy and google maps api - To get started please refer to the README.md - CONTRIBUTING.md and the project Wiki

https://navi-rocks.herokuapp.com/

MIT License

53 stars 63 forks source link

Pins cover map as you click around (even if you don't save the pins) #226

Closed steveone closed 6 years ago

steveone commented 6 years ago

This is a bug found in in the Enhance saved pin feature - Issue #204

If you click on multiple points of the map, each location will get a pin without you hitting "save" on the pins. The expected behavior is that one pin will be created, and if you don't hit "save" the pin will be removed when you click elsewhere on the map.

See attached screenshot for visual (taken in Chrome on a mac)

jkwening commented 6 years ago

@steveone want to take a crack at fixing this? If so, I'll assign the ticket to you.

The code logic is in ~/client/src/components/LeafletOSMMap/index.js. We're using Leaflet module for rendering maps.

steveone commented 6 years ago

@jkwening I'd be happy to take a crack and resolving this issue. Thanks for pointing out where the code is. I will take a look at it shortly.

jkwening commented 6 years ago

resolved in PR #244