TheDevPath / Navi

Open Source Project for Grow with Google Udacity Scholarship Challenge - Navigation app using offline first strategy and google maps api - To get started please refer to the README.md - CONTRIBUTING.md and the project Wiki
https://navi-rocks.herokuapp.com/
MIT License
53 stars 63 forks source link

Adding tests for search endpoints #262

Closed gabrielgrover closed 6 years ago

gabrielgrover commented 6 years ago

Issue Number: 78

Issue Description: Add unit test for search history end points

Summary of solution:

  1. Added tests for /search/history/* endpoints
  2. Fixed broken test in saved-pins-test.js and added another test for more coverage
  3. Added a utility function to seeds.js called userObjectWithToken(). It's purpose is to make user objects with a jwt when needed for tests.

Can this issue be closed?

yes

Should any new issues be added as a result of this solution?

We might want to add some unit tests for the models. It also will be a good idea to incorporate some sort of mock library for model tests so the tests are not hitting the DB.

Have you named your branch in a descriptive way? Remember to name your branch in a unique and descriptive manner in order to properly reflect the issue or feature.

yes