search

TheDevPath / Navi

Open Source Project for Grow with Google Udacity Scholarship Challenge - Navigation app using offline first strategy and google maps api - To get started please refer to the README.md - CONTRIBUTING.md and the project Wiki
https://navi-rocks.herokuapp.com/
MIT License
53 stars 63 forks source link

fixed type error in search component #273

Closed gabrielgrover closed 6 years ago

gabrielgrover commented 6 years ago

Issue Number: N/A

Issue Description: N/A

Summary of solution:

In its calls to the backend API, the search component was sending this.props.position.lat and this.props.position.lng for lat and lng fields respectively. However, if you look at the constructor it is storing the position object in this.state. Consequently, type errors were showing up in the console preventing the backed even hitting the google api to get results.

Can this issue be closed?

yes

Should any new issues be added as a result of this solution?

No

Have you named your branch in a descriptive way? Remember to name your branch in a unique and descriptive manner in order to properly reflect the issue or feature.

Yes search_component_type_err

gabrielgrover commented 6 years ago

@jkwening sorry about that. Yeah, the state object having a position key confused me. I reverted the change i made and removed position from the search component's state.

jkwening commented 6 years ago

@Euklidian-Space no problem, there was an error and it is now been resolved. Thanks for contributing!