search

TheDevPath / Navi

Open Source Project for Grow with Google Udacity Scholarship Challenge - Navigation app using offline first strategy and google maps api - To get started please refer to the README.md - CONTRIBUTING.md and the project Wiki
https://navi-rocks.herokuapp.com/
MIT License
53 stars 63 forks source link

248 geocode bug #283

Closed jkwening closed 6 years ago

jkwening commented 6 years ago

Issue Number:

248

Issue Description:

Server backend request replacement with device geolocation requests pose PR #282 verification.

Summary of solution:

  1. Use navigator.geolocation.getCurrentPosition in home screen for getting user location instead of backend server google geolocation request.
  2. For MapContainer component, instead of using backend server geolocation as backup, for now alert simply alert user unable to get their location.

Can this issue be closed?

already closed

Should any new issues be added as a result of this solution?

No

Have you named your branch in a descriptive way? Remember to name your branch in a unique and descriptive manner in order to properly reflect the issue or feature.

Thanks for contributing!

jkwening commented 6 years ago

@motosharpley merged this into development branch to make sure its updated in the base code base though the previous update was merged into "heroku-testing".