search

TheDevPath / Navi

Open Source Project for Grow with Google Udacity Scholarship Challenge - Navigation app using offline first strategy and google maps api - To get started please refer to the README.md - CONTRIBUTING.md and the project Wiki
https://navi-rocks.herokuapp.com/
MIT License
53 stars 63 forks source link

Trailing Commas user-controller.js #298

Closed someyoungideas closed 6 years ago

someyoungideas commented 6 years ago

I was curious if anyone has issues running the app with the trailing commas in users-controller.js? If so I have a branch with the fixes, but I was checking first because it seemed like something others may not have issues with in order to run the app. There are three of them in the controller in various locations.

In order to reproduce I am running npm run dev script and I am seeing the errors show as Syntax Error from nodemon.

Here are my specs:

NodeJS - v6.5.0 NPM - 5.7.1 MacBook Pro OS X El Capitan

someyoungideas commented 6 years ago

It seems like this is an issue with the version of NodeJS being used. I started using v8.5.0 and everything worked as expected. Maybe there should be a minimum requirements of NodeJS version in the README.md?

motosharpley commented 6 years ago

@someyoungideas sorry I didn't get to this sooner, what I would like to do is specify our engine in the package.json we started the project on node v8.9.0 and this is something I need to add for the deployment pipeline anyways. If you want to add this and the debug script in your PR #299 that would be great. Thanks

someyoungideas commented 6 years ago

Closing after merge of #299 PR