search

TheDevPath / Navi

Open Source Project for Grow with Google Udacity Scholarship Challenge - Navigation app using offline first strategy and google maps api - To get started please refer to the README.md - CONTRIBUTING.md and the project Wiki
https://navi-rocks.herokuapp.com/
MIT License
53 stars 63 forks source link

Searching While Awaiting Geolocation Feature #302

Open someyoungideas opened 6 years ago

someyoungideas commented 6 years ago

As I a user viewing the application for the first time I should have some visual notification that I have either denied geolocation, or that my geolocation is currently in process. Along with this visual notification I should also be allowed to use the search effectively. Currently if you have blocked geolocation or in the process of getting your current position the search is broken and is throwing errors due to userPosition not being set in the home route state.

jkwening commented 6 years ago

@someyoungideas great summary of the issue - I'll assign to you if you want to work on this issue.

Here's a useful reference doc for navigation.geolocation: https://developer.mozilla.org/en-US/docs/Web/API/Geolocation/Using_geolocation

someyoungideas commented 6 years ago

@jkwening I would be glad to take this issue. I may have some questions along the way. Would you like me to just post them in here and mention you as they come up, would there be a more preferred place?

jkwening commented 6 years ago

@someyoungideas assigned to you. Yeah, just post in here and mention me as they come up. Thanks!