SeedGenerator seeds are not working

TheDigitalFrontier / parallel-decision-trees

Semester project in CS205 Computing Foundations for Computational Science at Harvard School of Engineering and Applied Sciences, spring 2020.

MIT License

3 stars 1 forks source link

SeedGenerator seeds are not working #84

Closed johannes-kk closed 4 years ago

johannes-kk commented 4 years ago

Running the RandomForest with seed = 1337 gives inconsistent results, suggesting something is missing in the SeedGenerator implementation.

johannes-kk commented 4 years ago

Adding prints after random_forest.cpp line 122 shows data_seed and tree_seed are both consistent when RandomForest is initialised with the same master_seed.

wfseaton commented 4 years ago

Proposal for cause: https://github.com/johannes-kk/cs205_final_project/pull/85#discussion_r422434843