search

TheDigitalFrontier / parallel-decision-trees

Semester project in CS205 Computing Foundations for Computational Science at Harvard School of Engineering and Applied Sciences, spring 2020.
MIT License
3 stars 1 forks source link

Update API for `DecisionTree` and `RandomForest` to take test data in `.fit` method instead of constructor. #89

Closed gpestre closed 4 years ago

gpestre commented 4 years ago

Update API for DecisionTree and RandomForest to take test data in .fit method instead of constructor.

johannes-kk commented 4 years ago

Rejected in favour of PR #90.

Since we don't have functionality where passing separate x_train and y_train is natural, getting rid of fit() altogether and instead doing it in the constructor seems cleaner than expanding the arguably already superfluous fit() method.