TheDinos / pe

0 stars 0 forks source link

Schedule command produces the wrong CLI output when an appropriate deadline is given. #2

Open TheDinos opened 1 week ago

TheDinos commented 1 week ago

In the UG, the developers specified that the deadline is set to "None" by default, and whenever the command is called, the previous deadline is overwritten.

However, whenever a deadline is attached to a manga, the deadline "None" is said to be added to the manga as shown below:

image.png

image.png

However, the ammended deadline is shown when the "view" command is used:

image.png

When no deadline is given, which would be the interpretation for "None", the following result is shown:

image.png

The steps to reproduce would be to first catalog an author, and a manga tagged to the author, before trying to set the deadline.

Hence, while it does track the correct deadline, perhaps it is imperative that this CLI functionality is fixed immediately, given that it is one of the main functionalities of the app to track deadlines of authors under the users charge.

nus-se-script commented 1 week ago

Team's Response

The bug highlighted is indeed valid and was the result of a refactor of print statements into the Ui class. The team should have been more careful when testing the program and caught this. Ultimately, the team believes that the severity of the bug should be Low instead as only the incorrect message is provided to the user whereas the actual data is still modified behind the scenes i.e. this is a mere printing error. The data change can also be properly verified with the view command or by inspecting the json save file and does not hinder usage besides causing a minor inconvenience due to the misleading message.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]