search

TheDiscordian / disco-chat

A peer-to-peer messaging app.
MIT License
22 stars 2 forks source link

IPNS Profiles #18

Closed TheDiscordian closed 1 year ago

TheDiscordian commented 1 year ago

Currently a user announces nickname & profile picture with every single message send. It'd make more sense to not send this information at all, and retrieve it by doing an IPNS query on the PeerID.

TheDiscordian commented 1 year ago

Lots of work done here: https://github.com/TheDiscordian/disco-chat/commit/5e9f26d23b560b7916ba7943faee71f6f4f15749

TheDiscordian commented 1 year ago

Initial work completed (which is great). Next steps:

  1. Currently it works by doing an IPNS query in a lot of scenarios. We need to make sure this doesn't completely nuke any semblance of performance.
  2. Test this with multiple other clients. Change name / profile, send messages. See if everything still works as expected.
TheDiscordian commented 1 year ago
  1. Might need more testing but I didn't notice any performance impact. Would likely need to test with 5+ simultaneous users (and that's not a bar I want for this issue to close).
  2. Tested, works shockingly well with just 2 people.

Closing this ass it seems to tick the boxes. Needs more organization and documentation, but that's planned over one big cleanup near the end.