search

TheDuckCow / godot-road-generator

A godot plugin for creating 3D highways and streets.
MIT License
358 stars 18 forks source link

100-avoid showing repeats in add menu #103

Closed TheDuckCow closed 1 year ago

TheDuckCow commented 1 year ago

See the description in https://github.com/TheDuckCow/godot-road-generator/issues/100, goal here is to avoid repeats in the add UI. It now looks like this, which is desirable:

Screen Shot 2023-06-23 at 11 54 10 PM

Closes #100

bdog2112 commented 1 year ago

Hey @TheDuckCow, I see you already merged into dev. I did a quick check since you asked and a cursory glance indicated that these changes were sound and reasonable. I also loaded the "dev" branch, opened a pre-existing scene, and checked for errors. Then, added new RoadPoints via the Edit RoadPoint panel. Did not observe any errors and all GUT tests passed.

Also, "RoadSegment" did not show up in the Add menu as a standalone object, which seemed to be the intended outcome. Good work!

"RoadSegment(road_segment.gd)" did appear in the Add menu. But, I got the impression that was okay.

bdog2112 commented 1 year ago

After re-reading your first comment, I did a local git restore just to cleanup the directory. Then, one more git pull.

Now, "RoadSegment" no longer shows up and the "Add" list looks just like your screenshot.

TheDuckCow commented 1 year ago

Thanks for giving it a check and trying it out! Second pair of eyes is always good.