search

TheDuckCow / godot-road-generator

A godot plugin for creating 3D highways and streets.
MIT License
313 stars 16 forks source link

Generate signals on road updated #105

Closed TheDuckCow closed 1 year ago

TheDuckCow commented 1 year ago

Purpose of this change is to reliably generate a signal when any road segments have been updated, so that downstream listeners can react to the roads (and thus, lanes etc) being updated. It attempts to batch them as much as possible, so one overall rebuilding of all RoadSegments will yield in one signal call referencing all of those roads.

Not all tests pass right now, due to one recently added test that I thought was initially working but now is not (to with checking rebuild on certain conditions).

Will edit before merging to dev.

Totals
Scripts:          3
Passing tests     7
Failing tests     1 # test_on_road_updated_single_segment
Risky tests       0
Pending:          1 # func test_on_road_updated_pt_transform():
Asserts:          49 of 50 passed
TheDuckCow commented 1 year ago

Working well now. All but one tests are passing, which is due to a separate issue I'm going to resolve shortly around too-harsh validation checking which is getting in the way.

8 passed 1 failed. Tests finished in 1.2s