search

TheDuckCow / godot-road-generator

A godot plugin for creating 3D highways and streets.
MIT License
313 stars 16 forks source link

Persistent lane width and improved easing #112

Closed TheDuckCow closed 1 year ago

TheDuckCow commented 1 year ago

All tests pass:

12 passed 0 failed. Tests finished in 1.3s

See the change (going from the old way to the new way). This is essentially taking the best of both worlds (in terms of approaches we've tried so far) by having easing, while also ensuring consistent lane width.

changed

Need to do further checks to ensure the easing is also applied as necessary to the RoadLanes.

TheDuckCow commented 1 year ago

I would argue that RoadLanes are working no better or worse than before, it is a known issue that highly curvy segments of roads will not have properly aligned lanes. There are different plans on how to get that working, which are out of scope of this PR.

Screen Shot 2023-07-06 at 10 19 41 PM
TheDuckCow commented 1 year ago

Thanks for live testing! Glad to hear you didn't see any other artifacts - I think this video shows off the worse case scenarios in the original issue task: https://github.com/TheDuckCow/godot-road-generator/assets/2958461/1f792247-31ef-4178-bb14-b66650c1f00e

Merging shortly.