Restructure points and segments

TheDuckCow / godot-road-generator

A godot plugin for creating 3D highways and streets.

MIT License

358 stars 18 forks source link

Restructure points and segments #120

Closed TheDuckCow closed 1 year ago

TheDuckCow commented 1 year ago

WIP to change the structure as decided, and fixing of global rotation offsets applied by the RoadNetwork parent. WIP.

Closes #74 Closes #73

TheDuckCow commented 1 year ago

Hey @bdog2112 would be great if you can do a quick sanity review of this before I merge. Things to try:

Rotate or scale the root RoadNetwork as much as you like
Try in a scene that both does and doesn't have a pre-existing structure (you should find it auto moves RoadPoints to be direct children of RoadNetworks.
and double check that, like for me, all unit tests still pass.

This doesn't implement the change to "road container" yet, but that is my next step.

TheDuckCow commented 1 year ago

Thanks for the review @bdog2112 - I'm now seeing the same as you in the demo scene including those errors. However if I save and re-open the project as is, it starts to work without issue as expected. I'll still see if I can improve that experience, but given it's a one-time issue during conversion, I'm inclined to still move on here. Thanks for testing!