Occasional invalid set index low poly

TheDuckCow / godot-road-generator

A godot plugin for creating 3D highways and streets.

MIT License

328 stars 17 forks source link

Occasional invalid set index low poly #16

Closed TheDuckCow closed 1 year ago

TheDuckCow commented 1 year ago

WIP, not ready for review. Sequenced on top of #15 as that fix was stumbled upon while working on this issue #3

TheDuckCow commented 1 year ago

This is now working, and review ready. All tests pass.

This code change got a bit larger than intended, can be reviewed in two chunks:

First commit is a refactor to move the inner build loop into its own function (to make it easier to work with in the future), I didn't like how long that function was.
All other changes here

TheDuckCow commented 1 year ago

Thanks for the thorough reply and review. Indeed, the demo scene has some intentional "bad" setup just to see how it would behave. Additionally, not being visible on hiding is intentional, but seems like it should better auto-redraw once visible again. I'll play with that and turn that into another issue. Merging shortly.