search

TheDuckCow / godot-road-generator

A godot plugin for creating 3D highways and streets.
MIT License
316 stars 16 forks source link

Created Road Point Inspector panel #31

Closed bdog2112 closed 1 year ago

bdog2112 commented 1 year ago

Created Road Point Inspector panel and added a button that prints the name of the selected Road Point.

While making a lot of selections in the Scene panel, the following message appeared intermittently:

res://addons/road-generator/plugin.gd:36 - Attempt to call function 'hide_gizmo' in base 'previously freed instance' on a null instance. core/variant_call.cpp:1222 - Attempted method call on a deleted object.

Plugin.gd Line 36 does a check for a null Road Point before calling its "hide_gizmo" routine. In some cases, Godot may say a null object exists even though it is null. Running the null check through "is_instance_valid()" seemed to clear up the errors right away.

All GUT tests passed.

bdog2112 commented 1 year ago

if we can adjust the panel position that would be great

Please elaborate. Adjust panel position in what way?

Is there a way to move it up regarding the category?

I'm pretty certain the panel can be placed above "Script Variables". I'll let you know if there are any road blocks.

I personally prefer the style of referencing specific nodes once at the very top of the file

This makes sense. I'll implement the requested change.

bdog2112 commented 1 year ago

Hey @TheDuckCow, conflicts with the branch were created when the lane_segment branch was merged with main, yesterday. I'll manually resolve the conflicts. Please double-check your lane_segment functionality once everything is checked in.

bdog2112 commented 1 year ago

There was a conflict with recent changes to main. But, it was minor and only required moving a few lines of code.

Opened the demo scene, looked for any unusual errors and there were none. Ran GUT tests and all 4 test sequences passed.