RoadPoint gizmo handles not cleared when RoadNetwork is selected

[bdog2112]

In some scenarios, a selected RoadPoint's gizmo handles are not cleared when a different object is selected.

Steps to recreate problem:

• select single RoadPoint and observe that handles and lane widget are shown
• select RoadNetwork and observe that lane widget is hidden. But, gizmo handles are still shown.

Need to re-evaluate how selection/deselection is processed. There has been plenty of discussion about Godot selection quirks.

• Godot only displays handles on the primary selection
• There's no way to lookup the primary selection
• In the Scene dock, Godot treats the top-most selected item as the primary selection
• When multiple items are selected, Godot sorts them one way in the Scene dock. But, a completely different way in get_selected_nodes(). This means one cannot rely on the 1st item in get_selected_nodes() to be the primary selection.
• If two items are selected in the Scene dock and the primary selection is ctrl-clicked, then it will not be highlighted. Thus, it won't show up in get_selected_nodes(). But, it will still remain the primary selection as indicated by its white border rectangle.
• Scene dock triggers selection_changed on button down
• 3D view triggers selection_changed on button up

Consider the above limitations when developing a solution for this bug.

[bdog2112]

plugin._on_selection_changed() handles various tasks when the user makes a new selection. This includes, potentially, iterating the list of RoadPoint children in the "RoadNetwork.points" node and updating the visibility of their handles.

Pull Request #58 mentioned that it would be better if we didn't explicitly search for the "points" node since there may be more than one.

We currently track the last selected RoadPoint. Perhaps, we should simply track the last list of selected items. This would provide a complete list of previous selections to iterate without the need to search for points or traverse all the nodes in the scene.

[TheDuckCow]

AS discussed, there's a chance that Godot 4 may work "differently". Though likely we will need to do this differently anyways, we will hedge our bets and wait until our godot 4 migration in case there is a simpler procedure/approach.

[TheDuckCow]

Calling out this similar sounding bug fixed in yesterday's 3.5.2 release of Godot, not sure if this would actually affect our situation though

[bdog2112]

Either way, it's an improvement!

On 3/7/2023 6:52 AM, Patrick W. Crawford wrote:

Calling out this similar https://github.com/godotengine/godot/pull/67947 sounding bug fixed in yesterday's 3.5.2 release of Godot, not sure if this would actually affect our situation though

— Reply to this email directly, view it on GitHub https://github.com/TheDuckCow/godot-road-generator/issues/57#issuecomment-1458309339, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3UUTN2I4JNVB6F436SC7MLW25DSDANCNFSM6AAAAAAVEVBIEI. You are receiving this because you were assigned.Message ID: @.***>