search

TheDutchCoder / ColorConvert

A Sublime Text 2 plugin that converts CSS colors from hex to rgb and back
MIT License
55 stars 6 forks source link

Sublime Text 3 support #7

Closed alexilyaev closed 11 years ago

alexilyaev commented 11 years ago

I can't find the package using Package Control on Sublime Text 3. Any ETA when it's going to be supported?

TheDutchCoder commented 11 years ago

Not anytime soon, ST3 doesn't support a lot of packages that I use myself, nor is it released yet. I'm not sure how easy it would be to convert (probably not that hard), so I might install the beta and give it a shot somewhere later this year!

oliverseal commented 11 years ago

It's remarkably easy. For me, most of the packages I use have been switched over (except this one). If I get a moment some time in the next week or so I'll see if I can get it working and send you a pull request.

alexilyaev commented 11 years ago

Thanks Oliver. Would greatly appreciate that. Most of the packages I use also support ST3 already, and the rest are in the process.

On Tue, Nov 5, 2013 at 4:49 PM, Oliver Wilkerson notifications@github.comwrote:

It's remarkably easy. For me, most of the packages I use have been switched over (except this one). If I get a moment some time in the next week or so I'll see if I can get it working and send you a pull request.

— Reply to this email directly or view it on GitHubhttps://github.com/TheDutchCoder/ColorConvert/issues/7#issuecomment-27777968 .

TheDutchCoder commented 11 years ago

Merged! Thanks a bunch to @oliverseal

alexilyaev commented 11 years ago

That's great news!

When can we get it through Package Control: https://sublime.wbond.net/packages/CSS%20Color%20Converter

Still says it only supports ST2 and I can't find it when searching Package Control in ST3.

TheDutchCoder commented 11 years ago

Isn't PC supposed to automatically update packages? I've asked @wbond about this but never got a reply. I other need to resubmit the package and or update the description. Does anyone have experience with this? On Nov 6, 2013 3:20 AM, "Alex Ilyaev" notifications@github.com wrote:

That's great news!

When can we get it through Package Control: https://sublime.wbond.net/packages/CSS%20Color%20Converter

Still says it only supports ST2 and I can't find it when searching Package Control in ST3.

— Reply to this email directly or view it on GitHubhttps://github.com/TheDutchCoder/ColorConvert/issues/7#issuecomment-27850631 .

wbond commented 11 years ago

@TheDutchCoder Feel free to point me to the question so I can answer it.

TheDutchCoder commented 11 years ago

Hi Will,

I sent you an email on October 18th, but if you prefer I can also copy the question here ;-) Which is basically if I need to do anything in order to get my plugin updated in PC and/or if I need to resubmit a request on the feed (with maybe an updated description?).

Cheers, Reinier

On 6 November 2013 09:06, Will Bond notifications@github.com wrote:

@TheDutchCoder https://github.com/TheDutchCoder Feel free to point me to the question so I can answer it.

— Reply to this email directly or view it on GitHubhttps://github.com/TheDutchCoder/ColorConvert/issues/7#issuecomment-27875391 .

wbond commented 11 years ago

Heh, yeah, I have 700 unread emails in my inbox and the number grows everyday. :-)

You need to update the info for your plugin in the channel repo and send a pull request. https://github.com/wbond/package_control_channel/blob/master/repository/c.json#L1162

oliverseal commented 11 years ago

I can do this real quick. I already have it merged with upstream.

TheDutchCoder commented 11 years ago

I understand @wbond ;-)

@oliverseal that would be awesome, thanks!

oliverseal commented 11 years ago

@TheDutchCoder You might want to consider using tags to track versions so you can easily "release" updates to this.

git tag -a 0.1.1 -m "Version 0.1.1 Sublime Text 3 Support"
git push --tags

Later, say if you get the "convert all" functionality in there you could

git tag -a 0.2.1 -m "Version 0.2.1 Color Convert /all/ the things"
git push --tags

And git will do the versioning for you. NOTE: Package Control only accepts the Semantic Versioning number system (it's really simple).

For now, I've kept the tree/master in the c.json. (Since, ST3 users won't already have a version of this.)

TheDutchCoder commented 11 years ago

I don't know that much about Git, but thanks for the tip, I really need to get into Git much more. Too bad I don't use it at work (yet)! ;-)

On 6 November 2013 09:30, Oliver Wilkerson notifications@github.com wrote:

@TheDutchCoder https://github.com/TheDutchCoder You might want to consider using tags to track versions so you can easily "release" updates to this.

git tag -a 0.1.1 -m "Version 0.1.1 Sublime Text 3 Support" git push --tags

Later, say if you get the "convert all" functionality in there you could

git tag -a 0.2.1 -m "Version 0.2.1 Color Convert /all/ the things" git push --tags

And git will do the versioning for you. NOTE: Package Control only accepts the Semantic Versioninghttp://semver.orgnumber system (it's really simple).

For now, I've kept the tree/master in the c.json. (Since, ST3 users won't already have a version of this.)

— Reply to this email directly or view it on GitHubhttps://github.com/TheDutchCoder/ColorConvert/issues/7#issuecomment-27877308 .

oliverseal commented 11 years ago

I know what you mean. Getting my company to switch took years and a management change.

alexilyaev commented 11 years ago

Awesome, installed on ST3 through Package Control, works great.