search

TheELNConsortium / TheELNFileFormat

Specification for the ELN File Format
MIT License
45 stars 9 forks source link

refresh elabftw examples #33

Closed NicolasCARPi closed 1 year ago

NicolasCARPi commented 1 year ago

now Person/Comment/Mention are all "flattened", meaning they only point to an array of @id, and the node with the rest of the content is at the root.

FlorianRhiem commented 1 year ago

From how I understand RO-Crate, @id entries should be unique within the graph of a single ro-crate-metadata.json. That does not seem to be the case here, as there are two comments with an @id of comment://2023-09-28T03%3A44%3A52%2B02%3A00 in multiple-experiments.eln. While two comments being posted at exactly the same time is less likely to come up in practice, it might be better to avoid the risk by adding a counter or something like that?

NicolasCARPi commented 1 year ago

@FlorianRhiem good spot! These comments are created by a "populate" script, that's why they are in the same second. While your remark is very much valid, I'll just consider this a non-issue for now, as the risk is pretty low IMHO.

FlorianRhiem commented 1 year ago

In that case, maybe the script could be altered slightly to avoid this issue in the example, so that it contains valid JSON-LD?

NicolasCARPi commented 1 year ago

I'll resubmit an archive without this issue.