TheEconomist / us-potus-model

Code for a dynamic multilevel Bayesian model to predict US presidential elections. Written in R and Stan.
https://projects.economist.com/us-2020-forecast/president
MIT License
1.25k stars 191 forks source link

Unused parameter in stan model #17

Closed nesanders closed 4 years ago

nesanders commented 4 years ago

It looks like all references to the mu_b_T_model_estimation_error parameter are commented out in the poll_model_2020.stan model as well as poll_model_2020_no_mode_adjustment.stan. Presumably this variable should be removed from the parameters declaration. I'm not sure if this is the current Stan behavior, but there are at least some cases from past versions where unused parameters can negatively impact model behavior through unintended impacts on the posterior.

https://github.com/TheEconomist/us-potus-model/blob/85be55ae7b0bc68cb155a9ca975e155837eb4851/scripts/model/poll_model_2020.stan#L68

elliottmorris commented 4 years ago

fixed and closing