Open cameronjacoby opened 8 years ago
Hi @TheEddyChang - Here is your Project 3 feedback. Let me know if you have any questions about it! I encourage you to keep working on the project, as it's a great start, and I can tell it's something you're passionate about and excited to work on.
@zoejf - Feel free to add any other comments you have!
@TheEddyChang I second everything that Cameron said. You worked with a really tough API and I was really impressed by the perseverance you showed when you hit the ups and downs that came with it.
I especially agree with Cameron's comments about code cleanup and consistency - this should be your priority. Now that you have a little distance from the intensity of project week, I'd recommend that you try redoing some of your planning documents. This will help you figure out how each component relates to others and what you can get rid of. Lastly, I think the other thing that you should be doing is practice talking about the project and specifically how the code works. Especially being able to talk about what specific lines of the rake task do, as well as the probability calculations. Show your code to a classmate, or even someone who has no coding background and practice explaining things at a basic level.
Project Strengths
calculate_probability!
method. It's fairly impressive to dive into your own data analysis of any kind.scope
to pulltodays_games
from the database!Growth Opportunities
snake_case
in Rails for any variable names, method definitions, etc. that you have control over.@allGames
. Theshow
action should always relate to a single instance of any given resource.Game
model for calculating probability, and it deserves a test. :smile:README
file explaining a little about your project, the technologies you used, and how another developer could run the project locally. Follow the Project 3 Guidelines.bootstrap-sass
gem is in thedevelopment
group. Make sure to move it out, so the gem can work in production.todays_games_info
rake task to run every day on Heroku. Read about the Heroku Scheduler.