[BUG] TypeError in useAction when using a yup schema

[valentinludu]

Are you using the latest version of this library?

• [X] I verified that the issue exists in the latest next-safe-action release

Is there an existing issue for this?

• [X] I have searched the existing issues and found nothing that matches

Describe the bug

I tryied a zod schema and works fine.

But with a yup schema:

• useAction hook throws a type error when used with an action that has an yup schema.
• defineMetadataSchema throws a type error when defining a yup schema

Reproduction steps

Using "typescript": "^5.4.2", "@typeschema/yup": "^0.13.3", "next": "14.1.1", "react": "^18.2.0", "next-safe-action": "^7.1.0"

My client:

import type { IronSession } from 'iron-session';
import { getIronSession } from 'iron-session';
import { cookies } from 'next/headers';
import { createSafeActionClient } from 'next-safe-action/typeschema';
import * as yup from 'yup';

export const actionClient = createSafeActionClient({
  handleReturnedServerError: handleServerError,
  defineMetadataSchema: () => {
    return yup.object({
      actionName: yup.string()
    });
  }
})
.use(async ({ next }) => {
    const result = await next({ ctx: null });
    // log.info('LOGGING MIDDLEWARE FOR ACTION');
    return result;
})
.use(async ({ next }) => {
    const session = await getIronSession<SessionData>(cookies(), {});
    return next({
      ctx: { session }
    });
  });

defineMetadataSchema throws:

Using useAction in the FE throws a TypeError:

const { execute, executeAsync, result, status, reset, isIdle, isExecuting, hasSucceeded, hasErrored } = useAction(actionOnboarding);

useAction expects Zod:

Expected behavior

useAction should expect the yup schema and not the zod one. defineMetadataSchema should accept yup.

Minimal reproduction example

https://github.com

Operating System

macOS

Library version

7.1.0

Next.js version

14.1.1

Additional context

No response

[TheEdoRan]

Cannot reproduce the issue:

My guess is you just need to uninstall zod and @typeschema/zod, maybe delete node_modules and lockfile as well, then reinstall dependencies and reload the editor. TypeSchema works with dynamic imports and TypeScript magic, so it causes errors sometimes. If the issue persists I'll need a reproduction link to investigate this.

[valentinludu]

I tested it inside a CodeSandbox and the errors are not present. So it must be something on my end. I don't have "zod" and "@typeschema/zod" installed so I will try to delete node_modules, lock file and see if I get it to work.

Thank you for the quick response. I will try it out and come back if I have any issues.

[TheEdoRan]

Any updates on this issue?

[valentinludu]

After deleting package-lock and node_modules, now useAction types are working. On the other hand defineMetadataSchema is still throwing that type error. I just added @ts-ignore for now so I can continue my work.

[TheEdoRan]

Kinda weird, have you tried reloading the editor?

[valentinludu]

Yes. Still there.

[valentinludu]

Most certainly it's because I am in a monorepo. Unfortunately I can't pin where the actual problem is.

[TheEdoRan]

Does v7.2.0 solve this issue? next-safe-action now ships with built-in support for multiple validation libraries. You can find more information about that in this discussion and on this page of the website.

[valentinludu]

After I updated the lib to the latest version 7.4.1, all the TypeScript errors are gone. I tested with TypeScript 5.4 and 5.5 because I had an issue with v5.5. as well and that is fixed too.

Thanks a million. Issue can be closed!

[TheEdoRan]

That's great, thanks for the feedback!