search

TheElectronWill / night-config

Powerful java configuration library for toml, yaml, hocon, json and in-memory configurations. Serialization/deserialization framework.
GNU Lesser General Public License v3.0
242 stars 28 forks source link

Update HoconWriter to stop putting newlines at the head of the file #137

Closed 0x3C50 closed 1 year ago

TheElectronWill commented 1 year ago

Hi! It would be good to add some tests to prevent a regression :)

0x3C50 commented 1 year ago

Hi!

It would be good to add some tests to prevent a regression :)

I've tested it with the existing "tests" already, it works just as intended. The existing tests aren't really tests tho, since no assertions are actually made, but looking at the output, it works just fine

TheElectronWill commented 1 year ago

The existing tests aren't really tests tho, since no assertions are actually made,

Oops, you're right, I'll blame my past self for that one. I'll improve the tests in the future. Thank you for the PR!