search

TheEmeraldBee / widgetui

A bevy systems like widget system for ratatui and crossterm
MIT License
38 stars 5 forks source link

Update ratatui to 0.26.1 #3

Closed albinekb closed 8 months ago

albinekb commented 8 months ago

Thanks for making this! It's fun to play with 👏 I wanted to use the latest ratatui, and there was some minor changes needed. LMK if there's anything i need to change.

TheEmeraldBee commented 8 months ago

One of the tests is failing. If you could look at that and either change the test or fix that, that would be great, and I can then accept the pull request. Thank you!

albinekb commented 8 months ago

The test failed because:

  left: Rect { x: 26, y: 125, width: 204, height: 3 }
 right: Rect { x: 26, y: 128, width: 204, height: 3 }

Breaking change in 0.25: https://github.com/ratatui-org/ratatui/pull/881

Should we keep using Legacy flex, so it behaves like before? (pushed commit) Let me know if you'd like to use the new default Flex::Start and update the expected result in the test instead.

TheEmeraldBee commented 8 months ago

Lets update it.

albinekb commented 8 months ago

Great! Fixed ✅