TheEpicBlock / PolyMc

Making minecraft mods compatible with a vanilla client
GNU Lesser General Public License v3.0
557 stars 27 forks source link

Item texture overrides are ignored #110

Closed skerit closed 2 years ago

skerit commented 3 years ago

Texture overrides (like based on damage) are currently not yet ported to the poly model file. Take this example:

{
  "parent": "blackblock:item/key",
  "textures": {
    "layer0": "blackblock:item/wood_key"
  },
  "overrides": [
    {
      "predicate": {
        "damaged": 1,
        "damage": 0.5
      },
      "model": "blackblock:item/wood_key_damage_01"
    },
    {
      "predicate": {
        "damaged": 1,
        "damage": 0.3
      },
      "model": "blackblock:item/wood_key_damage_02"
    },
    {
      "predicate": {
        "damaged": 1,
        "damage": 0.1
      },
      "model": "blackblock:item/wood_key_damage_03"
    }
  ]
}

The override models are not copied to the resource pack, and they're not added to the warped_fungus_on_a_stick override model:

{
    "parent": "item/generated",
    "textures": {
        "layer0": "item/warped_fungus_on_a_stick"
    },
    "overrides": [{
        "predicate": {
            "custom_model_data": 1.0
        },
        "model": "blackblock:item/wood_key"
    }]
}

Doesn't seem to difficult to do, I might take a look at it.

TheEpicBlock commented 2 years ago

This (should) be fixed in b88ee00