search

TheEssem / mastodon

Chuckya, a glitch-soc fork used on wetdry.world
https://wetdry.world/@chuckya
GNU Affero General Public License v3.0
67 stars 9 forks source link

Add list of reactions #11

Open TheEssem opened 5 months ago

TheEssem commented 5 months ago

Work in progress. Currently only done on the API; working on exposing it in the UI.

This separates the status reaction serializer from the announcement reaction serializer to avoid breaking announcement reactions/exposing more info than needed.

To Do:

I'm really not too sure about the quality of this code, which is why I'm making a PR first...

TheEssem commented 4 months ago

@VyrCossont This should (hopefully) be reviewable now; note that the /reactions endpoint differs from the Firefish/Akkoma implementations in a few ways (reactions are paginated/sorted in descending order, each reaction is per-user, filtering is done through a query param). Remote users in the API responses/list UI are still untested because I don't have a proper environment for federation testing, but they should work in theory.

github-actions[bot] commented 4 months ago

This pull request has merge conflicts that must be resolved before it can be merged.

VyrCossont commented 4 months ago

Thank you! I'll take a look this weekend.

github-actions[bot] commented 4 months ago

This pull request has resolved merge conflicts and is ready for review.

ShadowJonathan commented 4 months ago

I'm mentioning https://github.com/glitch-soc/mastodon/pull/2462 real quick so there's a link to this somewhere other than the fedi post

github-actions[bot] commented 4 months ago

This pull request has merge conflicts that must be resolved before it can be merged.

github-actions[bot] commented 4 months ago

This pull request has resolved merge conflicts and is ready for review.

github-actions[bot] commented 4 months ago

This pull request has merge conflicts that must be resolved before it can be merged.

github-actions[bot] commented 4 months ago

This pull request has resolved merge conflicts and is ready for review.

github-actions[bot] commented 4 months ago

This pull request has merge conflicts that must be resolved before it can be merged.

github-actions[bot] commented 3 months ago

This pull request has resolved merge conflicts and is ready for review.

github-actions[bot] commented 3 months ago

This pull request has merge conflicts that must be resolved before it can be merged.

github-actions[bot] commented 3 months ago

This pull request has resolved merge conflicts and is ready for review.

TheEssem commented 3 months ago

Note to self: add a reactions_count parameter to status objects like with reblogs/favorites.

github-actions[bot] commented 2 months ago

This pull request has merge conflicts that must be resolved before it can be merged.

github-actions[bot] commented 1 month ago

This pull request has resolved merge conflicts and is ready for review.

github-actions[bot] commented 1 month ago

This pull request has merge conflicts that must be resolved before it can be merged.

TheEssem commented 1 month ago

Note to self: add a reactions_count parameter to status objects like with reblogs/favorites.

Progress has been made on this. However, there are still a few things I can't seem to figure out; this includes the updated reaction data not being sent when a reaction is destroyed and integration with the status relationships (which is important for serialization, performance, and fixing the aforementioned issue).

github-actions[bot] commented 1 month ago

This pull request has resolved merge conflicts and is ready for review.

github-actions[bot] commented 1 month ago

This pull request has merge conflicts that must be resolved before it can be merged.

github-actions[bot] commented 1 month ago

This pull request has resolved merge conflicts and is ready for review.

github-actions[bot] commented 2 weeks ago

This pull request has merge conflicts that must be resolved before it can be merged.