Setting visible reaction count to 0 does not hide them

TheEssem / mastodon

Chuckya, a glitch-soc fork used on wetdry.world

https://wetdry.world/@chuckya

GNU Affero General Public License v3.0

71 stars 9 forks source link

Setting visible reaction count to 0 does not hide them #19

Closed Makuramancer closed 3 months ago

Makuramancer commented 3 months ago

Steps to reproduce the problem

Set number of visible emoji reactions to 0 in user preferences

Expected behaviour

Reactions on posts are not visible at all

Actual behaviour

The setting is ignored, and reactions are displayed as if there wasn't a limitation set

Detailed description

Screenshot from 2024-06-16 18-47-31

Mastodon instance

wetdry.world

Mastodon version

v4.3.0-alpha.4+chuckya

Browser name and version

Firefox 127

Operating system

Fedora 40

Technical details

No response

Makuramancer commented 3 months ago

Setting reactions to even a very small number like 1 does not seem to make a difference

TheEssem commented 3 months ago

The setting looks to be meant for the in-timeline status view, where a smaller amount is required; I've gone ahead and made it so that it hides it completely on both views when set to 0 with 5668926ffa465ae09d17d2506bd8eb68100dd9c1.