search

TheExtensionLab / MegaMenu

Magento MegaMenu extension
27 stars 6 forks source link

Add span Tag Inside of Links #28

Closed sprankhub closed 8 years ago

sprankhub commented 8 years ago

It would be good if there was an additional span tag inside of the a tags. This would allow to hide the default text and replace it with an icon via CSS :before. For instance, here https://github.com/TheExtensionLab/MegaMenu/blob/master/app/design/frontend/base/default/template/theextensionlab/megamenu/page/html/topmenu/renderer.phtml#L22 replace:

<?php echo $this->escapeHtml($this->__($child->getName()))?>

with

<span><?php echo $this->escapeHtml($this->__($child->getName()))?></span>

This should be done in all default templates.

JamesAnelay commented 8 years ago

Thanks Simon this makes sense and seems to have no downside so I will implement this evening and aslong as it doesn't mess up the current css (I don't think it will).