search

TheExtensionLab / MegaMenu

Magento MegaMenu extension
27 stars 6 forks source link

Mobile Menu Arrow Not Shown for Span Parents #45

Closed sprankhub closed 8 years ago

sprankhub commented 8 years ago

In the mobile menu, an arrow is shown for links which have child elements, so that the user knows that there is something "behind" the link. The link could also be a span tag. Currently, there is no arrow for span elements which have child elements. In order to fix this, skin/frontend/base/default/scss/theextensionlab/megamenu/responsive.scss has to be edited.

Old selectors:

.megamenu-nav-primary li.parent > a:after {...}
[...]
.megamenu-nav-primary li.parent.menu-active > a:after {...}

New selectors:

.megamenu-nav-primary li.parent > a:after, .megamenu-nav-primary li.parent > span:after {...}
[...]
.megamenu-nav-primary li.parent.menu-active > a:after, .megamenu-nav-primary li.parent.menu-active > span:after {...}
JamesAnelay commented 8 years ago

Sorry for such a late reply here Simon! Quite right this is now fixed here : https://github.com/TheExtensionLab/MegaMenu/commit/ab2db6e4d62712258fc18de4c8dbe11a10298047

I will fold this on when I create a release for the SID issue.

Thanks again!

sprankhub commented 8 years ago

Thanks James! But you still have to run SASS again, so that the CSS files are changed as well :-)