search

TheFantasticWarrior / chrome-extension-imagus

"Mirror" of the "Mirror" of the official Imagus source hosted on Google Drive. currently taking a break on this project
https://addons.mozilla.org/en-US/firefox/addon/imagus-mod/
200 stars 7 forks source link

External Youtube videos do not work #25

Closed 54m4d closed 1 year ago

54m4d commented 1 year ago

Hello,

I have observed that the yt sieve does not function with external YouTube videos, such as those found on the Google search page, it is important to note that this issue is not related to the sieve itself, but rather with the extension, i have tested the original extension, and external YouTube videos play without any problems, therefore, it seems that no troubleshooting is required in this case, also no SMH is required.

Has this behavior been modified in the mod? or is there another factor contributing to this issue?

54m4d commented 1 year ago

You need to read

TheFantasticWarrior commented 1 year ago

21 I changed the xhr call from background script to the content script, which fixes cookie bugs on firefox(in incognito the cookie can be set/accessed by websites) but then the xhr call will be blocked by the browser CORS

maybe there are other ways to set the call as incognito in the background script, but I don't know how yet

https://www.reddit.com/r/imagus/comments/13kn4nu/firefox_private_mode_allows_for_setting_cookies/jqpw23k/?context=3 https://www.reddit.com/r/imagus/comments/121oop7/comment/jottktw/?utm_source=share&utm_medium=web2x&context=3

54m4d commented 1 year ago

Is it possible to allow the xhrs in Chrome, is it also affected?

TheFantasticWarrior commented 1 year ago

chrome doesn't have the bug, so I probably need to maintain 2 versions until I find another way, for now just use v0.10.11

TheFantasticWarrior commented 1 year ago

I separated the versions in v0.10.14, should work now

54m4d commented 1 year ago

Thanks for your effort!

Possible to remove Gecko only features from Chromium? like "Change file extensions (Firefox only?)"

TheFantasticWarrior commented 1 year ago

I haven't done thorough testing, it seems that chrome defaults(forces) the file extension, but after more searching I found this, on the first download call no file extension is used meaning the feature actually works on chrome too. I will edit the text in a future update

Also I removed most gecko only features, but probably missed some. I'll close this issue and if there are other features I missed make a new issue

54m4d commented 1 year ago

OK, if what i mentioned above applies to Chrome too, then all OK.