TheFantasticWarrior / chrome-extension-imagus

"Mirror" of the "Mirror" of the official Imagus source hosted on Google Drive. currently taking a break on this project
https://addons.mozilla.org/en-US/firefox/addon/imagus-mod/
216 stars 7 forks source link

"Enabled while holding ctrl" not working #5

Closed SpitFire-666 closed 1 year ago

SpitFire-666 commented 1 year ago

Extension works fine in the default "Disabled while holding CTRL", but doesn't seem to work when setting like this:

image

Thanks!

kuzn123 commented 1 year ago

You didn't specify which browser and extension version you have. It is also advisable to specify at least a few sites where this option does not work for you.

Does this functionality work for you in the original version of Imagus?

SpitFire-666 commented 1 year ago

My bad, using Firefox, Imagus mod v0.10.6.4. I can't get this function to work on any site.

Original Imagus works - have been using it for years (with the Enabled w/Ctrl option):

image

Imagus mod shows the dashed outline but Ctrl does not have any effect:

image

A couple websites:

https://www.bbc.co.uk/sounds/play/live:bbc_6music

https://www.bunnings.com.au/search/products?q=concrete+screw&sort=BoostOrder&page=3&pageSize=36

Cheers

TheFantasticWarrior commented 1 year ago

You have to hold control, THEN move the mouse cursor to an image, then stop the mouse, then up to you to release control or not. Tell me if it still doesn't work. I don't think I changed this part at all though.

edit: seems like the original works even with different order, will fix

TheFantasticWarrior commented 1 year ago

https://github.com/TheFantasticWarrior/chrome-extension-imagus/releases/tag/v0.10.7.1 should be fixed

NB! This version must be urgently removed from the releases - all files are saved (on Cent, by CTRL+S) as "undefined"...

kuzn123 commented 1 year ago

A couple websites:

I have on the current version (0.10.7) everything works correctly on your examples. On version 0.10.6.4, too, everything worked correctly.

TheFantasticWarrior commented 1 year ago

@kuzn123 If there are unrelated issues in a new update, please open a new issue and don't reopen unless the same issue is still broken

SpitFire-666 commented 1 year ago

Confirmed working with the new version, thankyou sir! (hope this didn't re-open the github issue)