TheFantasticWarrior / chrome-extension-imagus

"Mirror" of the "Mirror" of the official Imagus source hosted on Google Drive. currently taking a break on this project
https://addons.mozilla.org/en-US/firefox/addon/imagus-mod/
200 stars 7 forks source link

Problems with keyboard shortcuts #66

Open DenB10 opened 7 months ago

DenB10 commented 7 months ago

Hi TFW,

First of all, thank you for taking over the development of Imagus and making it even better.

I'm having trouble with the keyboard shortcuts, which seem to be designed for a QWERTY keyboard. However, I'm French and have an AZERTY keyboard, which causes confusion. For example, if I press the Z key to enter full zoom mode, the image undergoes a horizontal flip that is normally attributed to the W key.

The original Imagus didn't have this problem. Can you correct this?

Thank you.

attilaszkrs commented 7 months ago

The most frustrating extension I still use (or at least try to). Keyboard shortcuts are totally inconsistent, even on the same page to the point of the damn thing being unusable most of the time. It works when it is feeling like it, and doesn't when it isn't. I hope the project fails so I can have one less daily annoyance. In the meantime, I keep using it for the occasional dopamine rush and as a reminder of the complexities of the human condition.

TheFantasticWarrior commented 6 months ago

It was a long time ago, but I read that JavaScript keycode is deprecated (out of date) and the new code code keeps the locations on keyboard across different layouts instead of value (like Z in your example).

Eventually I will figure out a way to fix this, but sorry I'm temporarily not interested in this project anymore. Maybe set the keys to what you want to use and ignore that it displays wrong in the meantime

@attilaszkrs if you don't like it, just don't use it, or use the original imagus. Leaving negative comments won't help in any way. Sorry for not making this work correctly though but I can provide some help. Shortcut not working might be due to you changed the settings without reload or "not hovering correctly", I'm not sure what counts as correct hovering as I don't know how that part works yet, but it's mainly about the hover time and location I think.

DenB10 commented 6 months ago

@TheFantasticWarrior Thank you for your reply!

Eventually I will figure out a way to fix this

It would be nice indeed, I can be patient. In the meantime, all the best.