Hex characters not displaying properly

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Entering any menu with hex characters 
2.
3.

What is the expected output? What do you see instead?
The letters in the hex characters are overlapping causing them to truncate the 
first column or two. 

What version of the product are you using? On what operating system?
This appeared with the new fonts introduced in r277 when issue 189 was 
addressed.

Please provide any additional information below.

Original issue reported on code.google.com by charlesa...@comcast.net on 9 Dec 2010 at 12:22

[GoogleCodeExporter]

Yes it is true for me!

Original comment by mach3gmfc@gmail.com on 10 Dec 2010 at 2:12

[GoogleCodeExporter]

Eraz is working on this.  It was thought that since hex letters are displayed 
only for diagnostic purposes, so in the short term having truncated letters was 
okay.  But there is a fix planned for that very soon.

Original comment by torr...@gmail.com on 10 Dec 2010 at 5:55

[GoogleCodeExporter]

Erez, if we could have an additional flag somehow we could simply drop a column 
when rendering the letters (making A..F one pixel narrower).  This would look 
fine for A..F.  

I can see two ways to do this:  

1. use a larger mode parameter type (uint16, for example)
2. add another parameter to lcd_putcAtt(), perhaps with a default argument so 
we don't have to modify any other callers.

what do you recommend?  I'm not sure about 1, but I think I may experiment with 
option 2.

Original comment by torr...@gmail.com on 11 Dec 2010 at 6:00

[GoogleCodeExporter]

Here's a patch that fixes the hex display.  It adds an extra flag to 
lcd_putcAtt that defaults to 0.  I don't think it's too invasive...

Original comment by torr...@gmail.com on 11 Dec 2010 at 6:42

Attachments:

• hexpatch.patch

[GoogleCodeExporter]

Original comment by erezra...@gmail.com on 12 Dec 2010 at 5:14

• Changed state: Fixed