search

TheFinestArtist / FinestWebView-Android

Beautiful and customizable Android Activity that shows web pages within an app.
https://finestwebview.web.app
2.32k stars 532 forks source link

setWebViewClient to webView #31

Open fncapps opened 8 years ago

fncapps commented 8 years ago

Hi, I've been some days looking for methods in order to be able to download from the webview.

I have found a workaround based on WebClient but I first need to be able to do webView.setWebViewClient();

Could you add this functionality soon please? Thanks a lot!

EDIT: in fact I just need the shouldOverrideUrlLoading() not the whole WebViewClient I'm trying to develop this feature, in a couple of hours I'll send a pull request

TheFinestArtist commented 8 years ago

Hi @fncapps, can you tell me how you want to overrideUrlLoading? What kind of code you want to run on shouldOverrideUrlLoading() event?

fncapps commented 8 years ago

The idea was to look at the end of the URL for any kind of mimetype and start a download manager request if it was supposed to be downloaded.

The thing is that I recently found out this does not work with web pages that use php for example to trigger the download, so it is unnecessary.

The problem is that the method onStartDownload doesn't work neither.

HamedGh commented 7 years ago

I need it too

Cililing commented 5 years ago

Same here. No way to make custom WebViewClient... :/

IreshMM commented 5 years ago

Up voting for the request.