search

TheFinestArtist / FinestWebView-Android

Beautiful and customizable Android Activity that shows web pages within an app.
https://finestwebview.web.app
2.32k stars 531 forks source link

WebView onPageFinished #8

Closed fncapps closed 8 years ago

fncapps commented 8 years ago

Hi, it would be useful if you could directly add code from the builder to the onPageFinished method of the webView. In my case I would need to inject some javascript and that way it would be really easy.

Thanks for the library man

TheFinestArtist commented 8 years ago

@fncapps Got it! I will find out which way is best to send callback from on activity to other!

fncapps commented 8 years ago

Great! I also made a pull request, nothing big, just translation

TheFinestArtist commented 8 years ago

@fncapps I just seen it! You can actually use stringResRefresh stringResShareVia etc for translation!

TheFinestArtist commented 8 years ago

@fncapps Can you tell me what kind of javascript you want inject? or Can you give me some code samples? I don't really know where to start..

TheFinestArtist commented 8 years ago

@fncapps I think I did it, but I don't know whether I named the method properly or whether this is what you are looking for! Added 'injectJavaScript(String javaScript)` method.

fncapps commented 8 years ago

I've taken a look to the code, that should work! Thanks!

TheFinestArtist commented 8 years ago

@fncapps If you need some changes, please let me know or give me any pull request!