search

TheFive / osmbc

Open Street Map Blog Collector
MIT License
28 stars 11 forks source link

Bugfix/title image dimensions #1035

Closed call-me-matt closed 5 months ago

call-me-matt commented 5 months ago

this is a tiny extension to #976 Weekly 713 showed that the added dimensions were not sufficient for social media previews. A calendar icon was shown instead. So this pull request... ... increases the fallback image dimension to a width of 1111px ... also adds this to the div of the title image

call-me-matt commented 5 months ago

I updated the width on request of @Strubbl to a more common value (800px)

Strubbl commented 5 months ago

Did we clarify if a width is enough or height would also be needed?

call-me-matt commented 5 months ago

I think we tried it out and it was sufficient. In any case I do not feel comfortable in changing both values without reading image proportions. If you have a simple solution to that, please help. Otherwise, let's give it a try like this.

call-me-matt commented 5 months ago

well, I tried it out - and it seems faulty aspect ratios are without effect. So let's do it!

image

TheFive commented 5 months ago

its in production