search

TheFive / osmbc

Open Street Map Blog Collector
MIT License
28 stars 11 forks source link

Automatically generate OSMCal doesn't work #939

Closed s8321414 closed 1 year ago

s8321414 commented 2 years ago

When we press set to review button, OSMCal will automatically generate before, but this feature doesn't work now, maybe bring it back is a good idea?

TheFive commented 2 years ago

In Changelog it looks to work for several languages, is it a CN Specific problem, or does it occur on other languages although ?

s8321414 commented 2 years ago

In Changelog it looks to work for several languages, is it a CN Specific problem, or does it occur on other languages although ?

I have no idea, at least it doesn't work for ZH, maybe we should ask another language teams on Mattermost?

fredao commented 2 years ago

Issue checked: https://osmbc.openstreetmap.de/blog/edit/WN628 If I set a language here to Review, the "calendar" is created.

when I set a single language to Review, so here: https://osmbc.openstreetmap.de/blog/WN628 then it may work - or not. I have not yet identified when the calendar is generated and when it is not. It seems that the two buttons work differently.

TheFive commented 2 years ago

Thanks for your work, i will compare these Two buttons and their contrxtes they are working in

fredao commented 2 years ago

We thank you for your permanent improvement of OSMBC. Without your dedicated work it would not be possible to publish 13 languages at the same time.

TheFive commented 2 years ago

Update: This Hypothesis was wrong, background generation is using the save mechanism, that user is using with SAVE button after manual generation. Hypothesis:

as it took some time, the Event Article (ALL 13 languages) may be changed.

in the "interactive mode" generate it Manual, that is no problem, as during save the comparison to the former state is only done for one language, but the current saving in the background mechanism requires the event article not to be touched, to avoid any overwrite of manual work.

TheFive commented 2 years ago

btw: could you please explain a little bit more deep what "does nor work" mean ? if it works, there is a common sense, that there is a calendar in the markdown. Does "nothing" happen ? or is there an error message ? (please report always an error message event it is so shourt, as a hint for error searching, thanks) Which language failed, timestamp of fail ?

please note these infos down if you have such a fail again. I have extended log files a little bit and hope to find a hint where to search

TheFive commented 2 years ago

It seems that the two buttons work differently.

From code point of view the source is not the difference we are searching for.

The call, the button triggers is exactly the same and the function is exactly the same, thats just triggering the same Serverfunction.

Is this possibly a hint for a different user behavoiur ?. If you are in blog edit mode, you do not LOOK direct after the blog. It is generated in the background. If you start the review in the blog view, than the blog is visible and may be the event article is openend, which causes some conflict ?

s8321414 commented 2 years ago

btw: could you please explain a little bit more deep what "does nor work" mean ? if it works, there is a common sense, that there is a calendar in the markdown. Does "nothing" happen ? or is there an error message ? (please report always an error message event it is so shourt, as a hint for error searching, thanks) Which language failed, timestamp of fail ?

please note these infos down if you have such a fail again. I have extended log files a little bit and hope to find a hint where to search

I am in "Full" tab now, and I press "Set to review (ZH)" button then check "Upcoming Events" section, no Markdown is generated there. (After about 1 or 2 mins, it shows.)

TheFive commented 2 years ago
image

Did you mean the start 4 hours ago ?

in the history you can see, that the calendar was generated. Did you press reload, there will be no automatic refresh, the calendar is simply generated in the background with no feedback

TheFive commented 2 years ago

I will try to optimize performance https://github.com/TheFive/osmbc/issues/945

s8321414 commented 1 year ago

It seems to be fixed now.