TheFive / osmbc

Open Street Map Blog Collector
MIT License
28 stars 11 forks source link

OSMCal Icon is too large #961

Closed Strubbl closed 2 years ago

Strubbl commented 2 years ago

at the moment, the generated calendar has the OSMCal Icon, which is way too large. Can we give it a fixed smaller size, e.g. width/height=16px, during generation of the calendar? https://weeklyosm.eu

grafik

Strubbl commented 2 years ago

In the review page the calendar preview looks okay. Icon size is limited to a height of 16 px and thus looks okay.

TheFive commented 2 years ago

Weekly OSM Output

<a href="https://osmcal.org/event/1340/">
<img src="https://osmcal.org/static/osmcal/favicon.png" height="16"/>

The Same restriction is used in osmbc.openstreetmap.de on review page, here it is working

 <a href="https://osmcal.org/event/1340/">
<img src="https://osmcal.org/static/osmcal/favicon.png" height="16"/>
</a>

in my "local test environment" this is generated

 <a href="https://osmcal.org/event/1224/">
<img src="https://osmcal.org/static/osmcal/favicon.png" alt="osmcalpic" width="16" height="16">
</a>

I will check for the differrence, but what is different in the WP environment and he OSMBC Production environment, that the height is ignored in WP ?

TheFive commented 2 years ago

changing

osmcalpic: <img src="https://osmcal.org/static/osmcal/favicon.png" height=16 witdh=16/>
                                                                             ^^^^^

to

osmcalpic: <img src="https://osmcal.org/static/osmcal/favicon.png" height=16 width=16/>
                                                                             ^^^^^

hopefully will fix this issue ?

(editied)

Strubbl commented 2 years ago

I see no difference between your two lines

Strubbl commented 2 years ago

I just fiddled around with the Firefox web inspector directly on the weeklyosm.eu page. And i found out, that adding the width fixes the issue. Only providing the height didn't seem to scale the icon down to 16x16

~Where can i find the definition of :osmcalpic:?~

edit: found it in the backend in "Language Indicator Icons". Let's see if that helps already.

Strubbl commented 2 years ago

I see with the current WN this issue is fixed