TheFive / osmbc

Open Street Map Blog Collector
MIT License
28 stars 11 forks source link

Feature: Hide the warning of "Please enter your email to receive comments..." #993

Closed barefootstache closed 10 months ago

barefootstache commented 1 year ago

Issue

Currently there seems to be no option to hide this warning

Screenshot from 2023-06-18 15-39-47

which is fine on the browser on the PC, since one can just use the extension Stylus and add these lines

@-moz-document domain("osmbc.openstreetmap.de") {
    /* Insert code here... */
    #mailalert {
        display: none;
    }
}

Though on mobile that option of using an extension doesn't exist and over-bloats the screen as seen here

Screenshot_20230618-153622_1

Proposed Solution

Add a checkbox in the Configuration to hide this warning.

Strubbl commented 1 year ago

For a good collaboration it might be useful if you enter a mail address

TheFive commented 1 year ago

I have reviewed the standard generation of Users.

image

there is no mail forced to be send out from this.

TheFive commented 1 year ago

I have reviewed your personal user in OSMBC, you should only get emails for @DE or @EN mentions. and if the review status of EN is changing.

you can simply reduce that. (my personal recommendation is to simply get mails for @user mentions), but that is not enforced by the system.

if you are recieving more mails that described above, i would be interested in, as this looks to be an error in the Mail Notification module.

TheFive commented 10 months ago

as a first step i will deescalate the alert a little bit.

and i would like to understand, where a mail overflow comes from (may be the defaluts OSMBC is giving are wrong, or organisational defaults are wrong, or there is a bug in OSMBC sending to much emails)

TheFive commented 10 months ago

Will close the issue, lets discuss what is going wrong with the mail notification configuration on another issue.