TheFiveMemberTeam / Retrograde-DarkOrbit

0 stars 0 forks source link

US12 Ability function for increase/decrease status bar ability #83

Closed JacobAKnox closed 1 month ago

JacobAKnox commented 1 month ago

30 min

JacobAKnox commented 1 month ago

All the logic for the ability handler was already correct. What should have been done is write a function that conforms to the ability function definition: function ability(lobbycode, playerid, data) Then add that to the ability function map in get_ability_function with an appropriate key. Keys can be found under the ability key in role_data.json what you changed in use_ability should be undone

data is determined on the client side and should be unpacked in the ability function see #81 for more info on this system

Freddyh11 commented 1 month ago

@JacobAKnox, So should I revert back to the original code you had before? or is the implementation I had okay to keep and also add the changes you requested?

JacobAKnox commented 1 month ago

@Freddyh11 revert just the change in use_ability your implementation is redundant