search

TheFloydman / More-Mystcraft

Other
2 stars 1 forks source link

0.4.4 Client Crash - SymbolSunTinted$CelestialObject.render #11

Closed Odin-sama closed 5 years ago

Odin-sama commented 5 years ago

What version of More Mystcraft are you using? 0.4.4

What version of Mystcraft are you using? 0.13.7.02

What version of Forge are you using? 14.23.5.2806

What version of Minecraft are you using? 1.12.2

What modpack and modpack version are you using, if any? N/A (Custom)

Does the bug occur server-side, client-side, or both? Client-side

Paste a link to your log or crash report here. Use a service like pastebin. No images, please. https://pastebin.com/w81DjdZT

Describe the bug I've loaded a world without specification as to Sun parameters, save for 'Zenith Phase' expected to attach to it as a loose modifier. Tinted Sun nor any colors were specified from a page. Upon loading this world, client crashes with null pointer exception at More Mystcraft, appearing to have something to do with the way the mod handles Tinted Sun rendering. Maybe an invalid color attempting to render?

To Reproduce Steps to reproduce the behavior:

  1. [Generate world - Age parameters for sun were random]
  2. Client crashes upon loading new age. The dimension server-side was however, successfully created.

Expected behavior Load into world as expected without a crash.

Additional Information Server appears to generate no errors upon client crash besides reporting that a client timed out. The age appears to have successfully generated a DIM-MYST## folder and looks like a valid world. I can provide the Dimension folder in addition to a full world save and our custom mod pack to test with, if desired.

TheFloydman commented 5 years ago

Thank you for finding this. It appears I neglected to a null check on one of the variables in the Tinted Sun. I have updated it so that if it's null, it defaults to a yellow color, which should fix the problem. I know this is unlikely, but have you disabled the color pages in Mystcraft's symbols.cfg?

Odin-sama commented 5 years ago

Awesome response, and thanks for the quick fix. I've loaded it to my server and tested it in the client; The world loaded successfully! Looks like a white-ish sun generated. 2019-01-16_19 11 40

I did not disable colors in my symbols.cfg, no. I double-checked the file searching anything 'color' and it's all flagged for true.

I also had this pop up upon loading the server. Figured I'd let you know in case this happened to be unintentional:

_Missing minecraft:items: moremystcraft:maintainersuit

TheFloydman commented 5 years ago

Yeah, that last error is because I have a long-term project of adding a maintainer suit, and it shouldn't have been added to your game in the first place. You shouldn't see the error with future worlds you make.