search

TheFootballSocialClub / FSCRestBundle

DEPRECATED You should have a look at https://github.com/TheFootballSocialClub/FSCHateoasBundle ;-)
https://github.com/TheFootballSocialClub/FSCRestBundle
7 stars 5 forks source link

PHP 5.3 compatibility #3

Open stof opened 11 years ago

stof commented 11 years ago

Looking at the code, your bundle is not comaptible with PHP 5.3 as it relies on array dereferencing, which is 5.4 feature: https://github.com/TheFootballSocialClub/FSCRestBundle/blob/master/Controller/ResourceController.php#L48

You should either fix it or require php >= 5.4 in your composer.json

adrienbrault commented 11 years ago

Fixed in 26a6df7133d5c398f4ae59f985795c6852ece28d

stof commented 11 years ago

I would have preferred a fix to allow using the bundle on 5.3 (especially as you are only using small 5.4 features that can easily be replaced). I'm still working on 5.3 currently :)

adrienbrault commented 11 years ago

This bundle may be soon deprecated, in favor to ... https://github.com/TheFootballSocialClub/FSCHateoasBundle (leveraging JMSSerializerBundle 1.0.x) And this one is PHP 5.3 compatible from the start ;-)

But anyway, I'll have a look :)

stof commented 11 years ago

oh, I haven't seen you started a new one instead