search

TheFoundryVisionmongers / KatanaUsdPlugins

Katana USD Plugins Repo
Other
48 stars 20 forks source link

nested instances #18

Open ainaerco opened 3 years ago

ainaerco commented 3 years ago

Nested instances doesn't seem to be working. When we have assembly with components and both components and assemblies are instanced source paths are incorrect and this is printed in the log: Coding Error: in AppendPath at line 603 of /user_data/.tmp/bobscratch-CfktZd/build/pxr/usd/lib/sdf/path.cpp -- Cannot append to invalid path.

Comment in usdInPrivateData.cpp saying that current approach doesn't support nested instances. Would be great to have this fixed.

radon199 commented 3 years ago

This was fixed in the pixar plugin after this plugin was forked. The commit that fixes it was in 20.02 and can be found here :
https://github.com/PixarAnimationStudios/USD/commit/3b86661ad0a48fe9a14cb3878ce410a4a7570c3e

Would be great to port this.

JamesPedFoundry commented 3 years ago

Hi Ainaerco and Radon,

Thanks for raising the issue and also thanks for pointing us at the link to the patch! We forked during 19.11, so we will see which other patches from 20.02 we can pull across as well. (I now notice they also did a refactor of the repo, which we will not carry over). I've raised this internally under ID 463832.

Cheers, James