search

TheFreeman193 / PIFS

A collection of build properties for the PIF module
MIT License
505 stars 28 forks source link

all profiles excluded #8

Closed Roman860 closed 8 months ago

Roman860 commented 9 months ago

Run the script in termux Root with magisk The script worked about two weeks ago

===== PIFS Random Profile/Fingerprint Picker =====
 (Buy me a coffee: https://ko-fi.com/nickbissell)
============== v3 - collection v1.3 ==============

    Using busybox '/data/adb/magisk/busybox'

Looking for installed PIF module...
    PIF module found but not recognized! Will use /data/adb/pif.json

Detecting device ABI list...
    Will use profile/fingerprint with ABI list 'arm64-v8a,armeabi-v7a,armeabi'

Picking a random profile/fingerprint...
    Found excluded profile 'Meizu_meizu_PRO6Plus_PRO6Plus_7.0.0_NRD90M_m96.Flyme_7.0.1533805452_user_release-keys.json'. Moving to '/data/adb/pifs/failed'
    Found excluded profile 'nubia_NX619J-EEA_NX619J-EEA_9_PKQ1.180929.001_eng.nubia.20190929.101618_user_release-keys.json'. Moving to '/data/adb/pifs/failed'
    Found excluded profile 'Coolpad_C103_C1-INDIA_C103_6.0.1_ZIXOSOP5801803011S_0001832_user_release-keys.json'. Moving to '/data/adb/pifs/failed'
    Found excluded profile 'samsung_greatltexx_greatlte_9_PPR1.180610.011_N950FXXU5ZSAB_user_release-keys.json'. Moving to '/data/adb/pifs/failed'
    Found excluded profile 'asus_WW_Z01H_ASUS_Z01H_1_7.1.1_NMF26F_WW_user_71.60.139.30_20180306_user_release-keys.json'. Moving to '/data/adb/pifs/failed'
    Found excluded profile 'Xiaomi_oxygen_oxygen_7.1.1_NMF26F_V11.0.2.0.NDDCNXM_user_release-keys.json'. Moving to '/data/adb/pifs/failed'
    Found excluded profile 'ZTE_ZTE_WARP8_warp8_7.1.1_NMF26V_20181018.111136_user_release-keys.json'. Moving to '/data/adb/pifs/failed'
    Found excluded profile 'Huawei_PLK_hi3635_6.0_MRA58K_jenkins12300945_user_test-keys.json'. Moving to '/data/adb/pifs/failed'
    Found excluded profile 'GiONEE_F103_GiONEE_GBL7319_5.0_LRX21M_1446213931_user_release-keys.json'. Moving to '/data/adb/pifs/failed'
ERROR: Exhausted 10 attempts to pick a profile not in the failed list. Are all profiles excluded?
TheFreeman193 commented 9 months ago

Hi, this behaviour is a mistake on my part - excluding profiles that reappear in the JSON directory (for example after an update) shouldn't count towards attempts but it does.

I'll be releasing an update to the script later today which no longer removes failed profiles and instead tracks them entirely with /data/adb/pifs/failed.lst.

jan-glx commented 9 months ago

I think there might be an even bigger issue that all profiles are excluded when the initial exclude list is empty.

TheFreeman193 commented 9 months ago

@Roman860 I've pushed the latest changes - could you try again and let me know the results? Cheers.

@jan-glx There was a case in which this could happen with the v3 script. An empty line or empty list file with a single line break would cause grep to match anything - and thus nothing. This should be fixed now.