TheFrenchGhosty / TheFrenchGhostys-Ultimate-YouTube-DL-Scripts-Collection

The ultimate collection of scripts for YouTube-DL.
GNU General Public License v3.0
2.32k stars 126 forks source link

Revert #72/3b0cfaf - Not needed and causes missing metadata in some cases #77

Closed coletdjnz closed 2 years ago

coletdjnz commented 2 years ago

72 / 3b0cfaf introduced using --extractor-args youtube:player_client=android as a workaround for throttling, however this is no longer needed. By default, yt-dlp uses --extractor-args youtube:player_client=android,web (and yt-dlp also has n-sig transforming implemented now).

This should be reverted now as it can lead to missing metadata and formats in some cases. If the webpage fails to download (e.g. 429), you will be relying on metadata from the android client only, which does not include data such as upload date.

TheFrenchGhosty commented 2 years ago

This is known, and I've been planning to do it for a while, I've just been busy.

TheFrenchGhosty commented 2 years ago

Fixed in https://github.com/TheFrenchGhosty/TheFrenchGhostys-Ultimate-YouTube-DL-Scripts-Collection/commit/95490ac015d378a7ab2c2f2b7f8fb2982af1fda1