search

TheFuseLab / VL.Fuse

A library for visually programming on the GPU, built to enable rapid workflows and modular approaches to accelerated graphics, logic and computation.
https://www.thefuselab.io
MIT License
262 stars 21 forks source link

Discuss Fmod vs Mod #25

Closed texone closed 3 years ago

texone commented 3 years ago

Should we just use the glsl style Mod which is propably what people expect any advantage on using fmod?

everyoneishappy commented 3 years ago

I'd suggest to just provide both? I don't know if it's advantage so much as just slightly different behavior?

I've already got it in the FuseCommonSDF header, but will move it to FuseCoreMath // glsl style mod #ifndef mod #define mod(x, y) (x - y * floor((x) / y)) #endif

everyoneishappy commented 3 years ago

Ah they are both there already (mod is patched)

texone commented 3 years ago

Yes I am aware already used mod question is should we keep fmod or just remove it or add a help patch explaining both and add proper documention to both nodes to make sure which one to use