TheGag96 / sm64-port

A port of https://www.github.com/n64decomp/sm64 for modern devices.
https://discord.gg/7bcNTPK
12 stars 1 forks source link

Feature Request: Wallkick ++ #7

Open Mariosonicman91 opened 4 months ago

Mariosonicman91 commented 4 months ago

I'd love to see Mario be able to wall kick out of long jumps by timing it within a 5-6 frame window like in the OG game, and for the earlier you wall kick (either soft or hard bonk), the more momentum you retain, like a frame perfect wall kick but in a more... intentional way.

Mario should also detach from the wall by tapping Z.

These three things would make the new wall kick WAAAAY better! :D

Mariosonicman91 commented 4 months ago

I realized the LUA port is not available here and you are probably not affiliated with it.

TheGag96 commented 4 months ago

I didn't do the Lua port initially, but I did fix it up for them after learning about it. Sorry to say, but I'm not sure I can commit to doing more updates to this mod... Those aren't bad ideas, though! The tapping Z especially sounds so obvious, now that you say it. If you or someone else decided to open a pull request to implement that, I'd probably merge it.

Mariosonicman91 commented 4 months ago

I'll try my best to add it to the Lua mod, then I'll try for sm64 and sm64 port patches!

No promises, I'm inexperienced and have trouble with commitment. 😅

Do you think you can fix up the Lua port once more so you can wall kick out of a hard bonk? m.wallKickTimer is set to 5 when bonking but it doesn't work... Any theories why?

BTW when I say Lua I specifically refer to SM64 Coop Deluxe, though I am sure there are others forks that use Lua.

Mariosonicman91 commented 4 months ago

The patches are in C, correct?

TheGag96 commented 4 months ago

Right - this repo is a fork of the project that decompiled SM64 back into an editable C codebase. The extended moveset mod as I originally made it is just a bunch of modifications here. The patches you download from the release page are Git diffs that you could apply to the decomp, but you don't need to do that since you could just clone my fork.

I notice the Co-op Deluxe repo doesn't contain my mod - are you just copying it over from the old co-op?

Mariosonicman91 commented 4 months ago

I am indeed. I wonder why it isn't in the new versions, it works perfectly fine besides the fact that m.wallKickTimer doesn't work, which is still in the LUA library, so I have no idea why.